MAP_STACK fixes #2285
Merged
MAP_STACK fixes #2285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we're trying to install a stack within a reservation (uncommon and likely not sensible), we need to use the reservation's address not the address of the bottom of the stack. Fixes: #2252
Put backslashes in the 73nd column not 81st.
bsdjhb
reviewed
Jan 8, 2025
brooksdavis
force-pushed
the
vm_map_stack-fixes
branch
from
271d192 to
b1c070a
Compare
bsdjhb
approved these changes
Jan 9, 2025
Use typeof() to make CHERIBSDTEST_CHECK_CALL_ERROR compatible with functions that return pointers (e.g., mmap()). Print unexpected return values with %#p to support most integer values.
It doesn't make sense to insert a stack into a reservation so disallow MAP_FIXED|MAP_STACK with a valid capability in addr. It's still allowed to MAP_FIXED|MAP_STACK, but only if there's nothing in that location (and you shouldn't be doing that).
markjdb
approved these changes
Jan 9, 2025
brooksdavis
force-pushed
the
vm_map_stack-fixes
branch
from
b1c070a to
9426ade
Compare
bsdjhb
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the underlying issue in #2252 (failed vm_map_stack_lock due to write reservations) and then forbid the MAP_STACK within an existing reservation since it's not done anywhere and doesn't make much sense.